Add proper module api for node users#619
Merged
redonkulus merged 1 commit intomasterfrom Dec 20, 2016
Merged
Conversation
|
CLA is valid! |
|
Looks great, thanks! Tests even! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bugeats @ericf
Fixes #565
This add a simple API to get the path to a css file and also its contents.
One caveat here is that I changed
mainfrom exporting thebuild/pure-min.cssto exportingindex.js. Its technically a breaking change, but the previous behavior would fail because node cannot require a css file. I added thebrowserproperty back to the original file in case someone is bundling this package for the client.